Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS: migrate to AWS SDK v2 #37092

Merged
merged 40 commits into from
May 3, 2024
Merged

KMS: migrate to AWS SDK v2 #37092

merged 40 commits into from
May 3, 2024

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Apr 25, 2024 •
edited
Loading

Description

Relations

Closes #36178

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=kms

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kms Issues and PRs that pertain to the kms service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Apr 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 25, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@jar-b jar-b added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2024
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. labels Apr 25, 2024
@aristosvo aristosvo marked this pull request as ready for review April 26, 2024 11:00
@aristosvo aristosvo mentioned this pull request Apr 27, 2024
Merged
@ewbankkit ewbankkit self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
@ewbankkit
'findKey' -> 'findKeyInfo'.
84a435b
@ewbankkit
d/aws_kms_key: Migrate to AWS SDK for Go v2.
a50b9ea
@ewbankkit
kms: Reduce visibility of diff suppress.
d4992a9
@ewbankkit
Fix d/aws_kms_alias.
f4f41b0
@ewbankkit
kms: Reduce visibility of validators.
2844555
@ewbankkit
r/aws_kms_external_key: Migrate to AWS SDK for Go v2.
1897d4f
@ewbankkit
r/aws_kms_grant: Migrate to AWS SDK for Go v2.
c837f55
@ewbankkit
r/aws_kms_policy: Migrate to AWS SDK for Go v2.
b5a6926
@ewbankkit
d/aws_kms_public_key: Migrate to AWS SDK for Go v2.
6ee058c
@ewbankkit
r/aws_kms_replica_key: Migrate to AWS SDK for Go v2.
6939249
@ewbankkit
r/aws_kms_replica_external_key: Migrate to AWS SDK for Go v2.
05a1e29
@ewbankkit
d/aws_kms_secrets: Migrate to AWS SDK for Go v2.
80b77a8
@ewbankkit
kms: Migrate sweepers to AWS SDK for Go v2.
3a4a255
@ewbankkit
kms: Migrate cross service package calls to AWS SDK for Go v2.
4e3317c
@ewbankkit
kms: More visibility reduction.
4995bf5
@ewbankkit
kms: Even more visibility reduction.
0e15fe9
@ewbankkit
Fix semgrep 'ci.kms-in-var-name'.
8706873
@ewbankkit
Merge branch 'main' into HEAD
92653bc
@ewbankkit
r/aws_kms_key_policy: Fix "NotFoundException: Invalid keyId 'KMS Key …
21aebcb 
…Policy'".
@ewbankkit
Fix 'TestAccKMSKeyPolicy_iamRole' and 'TestAccKMSKeyPolicy_iamService…
0299e64 
…LinkedRole'.
@ewbankkit
Fix golangci-lint 'unparam'.
7af39dd
@ewbankkit
Fix golangci-lint 'gomnd'.
1e07b5e
ewbankkit
ewbankkit approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKMS' PKG=kms ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/kms/... -v -count 1 -parallel 4  -run=TestAccKMS -timeout 720m
=== RUN   TestAccKMSAliasDataSource_service
=== PAUSE TestAccKMSAliasDataSource_service
=== RUN   TestAccKMSAliasDataSource_cmk
=== PAUSE TestAccKMSAliasDataSource_cmk
=== RUN   TestAccKMSAlias_basic
=== PAUSE TestAccKMSAlias_basic
=== RUN   TestAccKMSAlias_disappears
=== PAUSE TestAccKMSAlias_disappears
=== RUN   TestAccKMSAlias_Name_generated
=== PAUSE TestAccKMSAlias_Name_generated
=== RUN   TestAccKMSAlias_namePrefix
=== PAUSE TestAccKMSAlias_namePrefix
=== RUN   TestAccKMSAlias_updateKeyID
=== PAUSE TestAccKMSAlias_updateKeyID
=== RUN   TestAccKMSAlias_multipleAliasesForSameKey
=== PAUSE TestAccKMSAlias_multipleAliasesForSameKey
=== RUN   TestAccKMSAlias_arnDiffSuppress
=== PAUSE TestAccKMSAlias_arnDiffSuppress
=== RUN   TestAccKMSCiphertextDataSource_basic
=== PAUSE TestAccKMSCiphertextDataSource_basic
=== RUN   TestAccKMSCiphertextDataSource_validate
=== PAUSE TestAccKMSCiphertextDataSource_validate
=== RUN   TestAccKMSCiphertextDataSource_Validate_withContext
=== PAUSE TestAccKMSCiphertextDataSource_Validate_withContext
=== RUN   TestAccKMSCiphertext_basic
=== PAUSE TestAccKMSCiphertext_basic
=== RUN   TestAccKMSCiphertext_validate
=== PAUSE TestAccKMSCiphertext_validate
=== RUN   TestAccKMSCiphertext_Validate_withContext
=== PAUSE TestAccKMSCiphertext_Validate_withContext
=== RUN   TestAccKMSExternalKey_basic
=== PAUSE TestAccKMSExternalKey_basic
=== RUN   TestAccKMSExternalKey_disappears
=== PAUSE TestAccKMSExternalKey_disappears
=== RUN   TestAccKMSExternalKey_multiRegion
=== PAUSE TestAccKMSExternalKey_multiRegion
=== RUN   TestAccKMSExternalKey_deletionWindowInDays
=== PAUSE TestAccKMSExternalKey_deletionWindowInDays
=== RUN   TestAccKMSExternalKey_description
=== PAUSE TestAccKMSExternalKey_description
=== RUN   TestAccKMSExternalKey_enabled
=== PAUSE TestAccKMSExternalKey_enabled
=== RUN   TestAccKMSExternalKey_keyMaterialBase64
=== PAUSE TestAccKMSExternalKey_keyMaterialBase64
=== RUN   TestAccKMSExternalKey_policy
=== PAUSE TestAccKMSExternalKey_policy
=== RUN   TestAccKMSExternalKey_policyBypass
=== PAUSE TestAccKMSExternalKey_policyBypass
=== RUN   TestAccKMSExternalKey_tags
=== PAUSE TestAccKMSExternalKey_tags
=== RUN   TestAccKMSExternalKey_validTo
=== PAUSE TestAccKMSExternalKey_validTo
=== RUN   TestAccKMSGrant_basic
=== PAUSE TestAccKMSGrant_basic
=== RUN   TestAccKMSGrant_withConstraints
=== PAUSE TestAccKMSGrant_withConstraints
=== RUN   TestAccKMSGrant_withRetiringPrincipal
=== PAUSE TestAccKMSGrant_withRetiringPrincipal
=== RUN   TestAccKMSGrant_bare
=== PAUSE TestAccKMSGrant_bare
=== RUN   TestAccKMSGrant_arn
=== PAUSE TestAccKMSGrant_arn
=== RUN   TestAccKMSGrant_asymmetricKey
=== PAUSE TestAccKMSGrant_asymmetricKey
=== RUN   TestAccKMSGrant_disappears
=== PAUSE TestAccKMSGrant_disappears
=== RUN   TestAccKMSGrant_crossAccountARN
=== PAUSE TestAccKMSGrant_crossAccountARN
=== RUN   TestAccKMSGrant_service
=== PAUSE TestAccKMSGrant_service
=== RUN   TestAccKMSKeyDataSource_byKeyARN
=== PAUSE TestAccKMSKeyDataSource_byKeyARN
=== RUN   TestAccKMSKeyDataSource_byKeyID
=== PAUSE TestAccKMSKeyDataSource_byKeyID
=== RUN   TestAccKMSKeyDataSource_byAliasARN
=== PAUSE TestAccKMSKeyDataSource_byAliasARN
=== RUN   TestAccKMSKeyDataSource_byAliasID
=== PAUSE TestAccKMSKeyDataSource_byAliasID
=== RUN   TestAccKMSKeyDataSource_grantToken
=== PAUSE TestAccKMSKeyDataSource_grantToken
=== RUN   TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== RUN   TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== RUN   TestAccKMSKeyPolicy_basic
=== PAUSE TestAccKMSKeyPolicy_basic
=== RUN   TestAccKMSKeyPolicy_disappears
=== PAUSE TestAccKMSKeyPolicy_disappears
=== RUN   TestAccKMSKeyPolicy_bypass
=== PAUSE TestAccKMSKeyPolicy_bypass
=== RUN   TestAccKMSKeyPolicy_bypassUpdate
=== PAUSE TestAccKMSKeyPolicy_bypassUpdate
=== RUN   TestAccKMSKeyPolicy_keyIsEnabled
=== PAUSE TestAccKMSKeyPolicy_keyIsEnabled
=== RUN   TestAccKMSKeyPolicy_iamRole
=== PAUSE TestAccKMSKeyPolicy_iamRole
=== RUN   TestAccKMSKeyPolicy_iamRoleUpdate
=== PAUSE TestAccKMSKeyPolicy_iamRoleUpdate
=== RUN   TestAccKMSKeyPolicy_iamRoleOrder
=== PAUSE TestAccKMSKeyPolicy_iamRoleOrder
=== RUN   TestAccKMSKeyPolicy_iamServiceLinkedRole
=== PAUSE TestAccKMSKeyPolicy_iamServiceLinkedRole
=== RUN   TestAccKMSKeyPolicy_booleanCondition
=== PAUSE TestAccKMSKeyPolicy_booleanCondition
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== RUN   TestAccKMSKey_disappears
=== PAUSE TestAccKMSKey_disappears
=== RUN   TestAccKMSKey_multiRegion
=== PAUSE TestAccKMSKey_multiRegion
=== RUN   TestAccKMSKey_asymmetricKey
=== PAUSE TestAccKMSKey_asymmetricKey
=== RUN   TestAccKMSKey_hmacKey
=== PAUSE TestAccKMSKey_hmacKey
=== RUN   TestAccKMSKey_Policy_basic
=== PAUSE TestAccKMSKey_Policy_basic
=== RUN   TestAccKMSKey_Policy_bypass
=== PAUSE TestAccKMSKey_Policy_bypass
=== RUN   TestAccKMSKey_Policy_bypassUpdate
=== PAUSE TestAccKMSKey_Policy_bypassUpdate
=== RUN   TestAccKMSKey_Policy_iamRole
=== PAUSE TestAccKMSKey_Policy_iamRole
=== RUN   TestAccKMSKey_Policy_iamRoleUpdate
=== PAUSE TestAccKMSKey_Policy_iamRoleUpdate
=== RUN   TestAccKMSKey_Policy_iamRoleOrder
=== PAUSE TestAccKMSKey_Policy_iamRoleOrder
=== RUN   TestAccKMSKey_Policy_iamServiceLinkedRole
=== PAUSE TestAccKMSKey_Policy_iamServiceLinkedRole
=== RUN   TestAccKMSKey_Policy_booleanCondition
=== PAUSE TestAccKMSKey_Policy_booleanCondition
=== RUN   TestAccKMSKey_isEnabled
=== PAUSE TestAccKMSKey_isEnabled
=== RUN   TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== RUN   TestAccKMSKey_ignoreTags
=== PAUSE TestAccKMSKey_ignoreTags
=== RUN   TestAccKMSKey_updateTagsEmptyValue
=== PAUSE TestAccKMSKey_updateTagsEmptyValue
=== RUN   TestAccKMS_serial
=== PAUSE TestAccKMS_serial
=== RUN   TestAccKMSPublicKeyDataSource_basic
=== PAUSE TestAccKMSPublicKeyDataSource_basic
=== RUN   TestAccKMSPublicKeyDataSource_encrypt
=== PAUSE TestAccKMSPublicKeyDataSource_encrypt
=== RUN   TestAccKMSReplicaExternalKey_basic
=== PAUSE TestAccKMSReplicaExternalKey_basic
=== RUN   TestAccKMSReplicaExternalKey_descriptionAndEnabled
=== PAUSE TestAccKMSReplicaExternalKey_descriptionAndEnabled
=== RUN   TestAccKMSReplicaExternalKey_policy
=== PAUSE TestAccKMSReplicaExternalKey_policy
=== RUN   TestAccKMSReplicaExternalKey_tags
=== PAUSE TestAccKMSReplicaExternalKey_tags
=== RUN   TestAccKMSReplicaKey_basic
=== PAUSE TestAccKMSReplicaKey_basic
=== RUN   TestAccKMSReplicaKey_disappears
=== PAUSE TestAccKMSReplicaKey_disappears
=== RUN   TestAccKMSReplicaKey_descriptionAndEnabled
=== PAUSE TestAccKMSReplicaKey_descriptionAndEnabled
=== RUN   TestAccKMSReplicaKey_policy
=== PAUSE TestAccKMSReplicaKey_policy
=== RUN   TestAccKMSReplicaKey_tags
=== PAUSE TestAccKMSReplicaKey_tags
=== RUN   TestAccKMSReplicaKey_twoReplicas
=== PAUSE TestAccKMSReplicaKey_twoReplicas
=== RUN   TestAccKMSSecretDataSource_removed
=== PAUSE TestAccKMSSecretDataSource_removed
=== RUN   TestAccKMSSecretsDataSource_basic
=== PAUSE TestAccKMSSecretsDataSource_basic
=== RUN   TestAccKMSSecretsDataSource_asymmetric
=== PAUSE TestAccKMSSecretsDataSource_asymmetric
=== CONT  TestAccKMSAliasDataSource_service
=== CONT  TestAccKMSKeyPolicy_disappears
=== CONT  TestAccKMSSecretsDataSource_asymmetric
=== CONT  TestAccKMSSecretsDataSource_basic
--- PASS: TestAccKMSAliasDataSource_service (20.26s)
=== CONT  TestAccKMSKey_Policy_iamServiceLinkedRole
--- PASS: TestAccKMSKeyPolicy_disappears (35.60s)
=== CONT  TestAccKMSSecretDataSource_removed
--- PASS: TestAccKMSSecretDataSource_removed (4.03s)
=== CONT  TestAccKMSReplicaKey_twoReplicas
--- PASS: TestAccKMSSecretsDataSource_basic (49.64s)
=== CONT  TestAccKMSReplicaKey_tags
--- PASS: TestAccKMSSecretsDataSource_asymmetric (49.67s)
=== CONT  TestAccKMSReplicaKey_policy
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (58.16s)
=== CONT  TestAccKMSReplicaKey_descriptionAndEnabled
--- PASS: TestAccKMSReplicaKey_twoReplicas (64.25s)
=== CONT  TestAccKMSReplicaKey_disappears
--- PASS: TestAccKMSReplicaKey_policy (109.46s)
=== CONT  TestAccKMSReplicaKey_basic
--- PASS: TestAccKMSReplicaKey_disappears (65.38s)
=== CONT  TestAccKMSReplicaExternalKey_tags
--- PASS: TestAccKMSReplicaKey_basic (53.80s)
=== CONT  TestAccKMSReplicaExternalKey_policy
--- PASS: TestAccKMSReplicaKey_tags (192.70s)
=== CONT  TestAccKMSReplicaExternalKey_descriptionAndEnabled
--- PASS: TestAccKMSReplicaKey_descriptionAndEnabled (230.59s)
=== CONT  TestAccKMSReplicaExternalKey_basic
--- PASS: TestAccKMSReplicaExternalKey_policy (117.46s)
=== CONT  TestAccKMSPublicKeyDataSource_encrypt
--- PASS: TestAccKMSPublicKeyDataSource_encrypt (23.04s)
=== CONT  TestAccKMSPublicKeyDataSource_basic
--- PASS: TestAccKMSReplicaExternalKey_tags (192.77s)
=== CONT  TestAccKMS_serial
=== RUN   TestAccKMS_serial/CustomKeyStore
=== RUN   TestAccKMS_serial/CustomKeyStore/DataSource_basic
    custom_key_store_data_source_test.go:22: Environment variable CLOUD_HSM_CLUSTER_ID is not set, skipping test
=== RUN   TestAccKMS_serial/CustomKeyStore/basic
    custom_key_store_test.go:29: Environment variable CLOUD_HSM_CLUSTER_ID is not set, skipping test
=== RUN   TestAccKMS_serial/CustomKeyStore/update
    custom_key_store_test.go:68: Environment variable CLOUD_HSM_CLUSTER_ID is not set, skipping test
=== RUN   TestAccKMS_serial/CustomKeyStore/disappears
    custom_key_store_test.go:108: Environment variable CLOUD_HSM_CLUSTER_ID is not set, skipping test
--- PASS: TestAccKMS_serial (0.00s)
    --- PASS: TestAccKMS_serial/CustomKeyStore (0.00s)
        --- SKIP: TestAccKMS_serial/CustomKeyStore/DataSource_basic (0.00s)
        --- SKIP: TestAccKMS_serial/CustomKeyStore/basic (0.00s)
        --- SKIP: TestAccKMS_serial/CustomKeyStore/update (0.00s)
        --- SKIP: TestAccKMS_serial/CustomKeyStore/disappears (0.00s)
=== CONT  TestAccKMSKey_updateTagsEmptyValue
--- PASS: TestAccKMSPublicKeyDataSource_basic (20.64s)
=== CONT  TestAccKMSKey_ignoreTags
--- PASS: TestAccKMSReplicaExternalKey_basic (65.30s)
=== CONT  TestAccKMSKey_tags
--- PASS: TestAccKMSKey_updateTagsEmptyValue (48.37s)
=== CONT  TestAccKMSKey_isEnabled
--- PASS: TestAccKMSKey_ignoreTags (63.65s)
=== CONT  TestAccKMSKey_Policy_booleanCondition
--- PASS: TestAccKMSKey_Policy_booleanCondition (24.93s)
=== CONT  TestAccKMSExternalKey_policy
--- PASS: TestAccKMSKey_tags (96.94s)
=== CONT  TestAccKMSKeyPolicy_basic
--- PASS: TestAccKMSReplicaExternalKey_descriptionAndEnabled (231.52s)
=== CONT  TestAccKMSKeyDataSource_multiRegionConfigurationByID
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByID (28.68s)
=== CONT  TestAccKMSKeyDataSource_multiRegionConfigurationByARN
--- PASS: TestAccKMSExternalKey_policy (57.88s)
=== CONT  TestAccKMSKeyDataSource_grantToken
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByARN (21.46s)
=== CONT  TestAccKMSKeyDataSource_byAliasID
--- PASS: TestAccKMSKeyPolicy_basic (67.27s)
=== CONT  TestAccKMSKeyDataSource_byAliasARN
--- PASS: TestAccKMSKeyDataSource_byAliasID (24.10s)
=== CONT  TestAccKMSKeyDataSource_byKeyID
--- PASS: TestAccKMSKey_isEnabled (139.47s)
=== CONT  TestAccKMSKeyDataSource_byKeyARN
--- PASS: TestAccKMSKeyDataSource_grantToken (36.42s)
=== CONT  TestAccKMSGrant_service
--- PASS: TestAccKMSKeyDataSource_byAliasARN (28.66s)
=== CONT  TestAccKMSGrant_crossAccountARN
    grant_test.go:252: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== CONT  TestAccKMSGrant_disappears
--- SKIP: TestAccKMSGrant_crossAccountARN (0.00s)
--- PASS: TestAccKMSKeyDataSource_byKeyID (28.74s)
=== CONT  TestAccKMSGrant_asymmetricKey
--- PASS: TestAccKMSKeyDataSource_byKeyARN (28.12s)
=== CONT  TestAccKMSGrant_arn
--- PASS: TestAccKMSGrant_service (32.45s)
=== CONT  TestAccKMSGrant_bare
--- PASS: TestAccKMSGrant_arn (33.71s)
=== CONT  TestAccKMSGrant_withRetiringPrincipal
--- PASS: TestAccKMSGrant_asymmetricKey (35.58s)
=== CONT  TestAccKMSGrant_withConstraints
--- PASS: TestAccKMSGrant_bare (33.38s)
=== CONT  TestAccKMSGrant_basic
--- PASS: TestAccKMSGrant_withRetiringPrincipal (31.82s)
=== CONT  TestAccKMSExternalKey_validTo
--- PASS: TestAccKMSGrant_basic (30.89s)
=== CONT  TestAccKMSExternalKey_tags
--- PASS: TestAccKMSGrant_withConstraints (47.75s)
=== CONT  TestAccKMSExternalKey_policyBypass
--- PASS: TestAccKMSExternalKey_policyBypass (24.38s)
=== CONT  TestAccKMSCiphertextDataSource_Validate_withContext
--- PASS: TestAccKMSCiphertextDataSource_Validate_withContext (17.96s)
=== CONT  TestAccKMSExternalKey_keyMaterialBase64
--- PASS: TestAccKMSExternalKey_tags (81.91s)
=== CONT  TestAccKMSExternalKey_enabled
--- PASS: TestAccKMSGrant_disappears (211.58s)
=== CONT  TestAccKMSExternalKey_description
--- PASS: TestAccKMSExternalKey_validTo (156.00s)
=== CONT  TestAccKMSExternalKey_deletionWindowInDays
--- PASS: TestAccKMSExternalKey_keyMaterialBase64 (109.89s)
=== CONT  TestAccKMSExternalKey_multiRegion
--- PASS: TestAccKMSExternalKey_description (43.33s)
=== CONT  TestAccKMSExternalKey_disappears
--- PASS: TestAccKMSExternalKey_deletionWindowInDays (37.25s)
=== CONT  TestAccKMSExternalKey_basic
--- PASS: TestAccKMSExternalKey_multiRegion (25.12s)
=== CONT  TestAccKMSCiphertext_Validate_withContext
--- PASS: TestAccKMSExternalKey_disappears (23.21s)
=== CONT  TestAccKMSCiphertext_validate
--- PASS: TestAccKMSCiphertext_Validate_withContext (22.64s)
=== CONT  TestAccKMSCiphertext_basic
--- PASS: TestAccKMSExternalKey_basic (26.98s)
=== CONT  TestAccKMSKey_disappears
--- PASS: TestAccKMSCiphertext_validate (21.91s)
=== CONT  TestAccKMSKey_Policy_iamRoleOrder
--- PASS: TestAccKMSCiphertext_basic (22.18s)
=== CONT  TestAccKMSKey_Policy_iamRoleUpdate
--- PASS: TestAccKMSExternalKey_enabled (150.39s)
=== CONT  TestAccKMSKey_Policy_iamRole
--- PASS: TestAccKMSKey_disappears (22.56s)
=== CONT  TestAccKMSKey_Policy_bypassUpdate
--- PASS: TestAccKMSKey_Policy_iamRole (39.60s)
=== CONT  TestAccKMSKey_Policy_bypass
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (58.93s)
=== CONT  TestAccKMSKey_Policy_basic
--- PASS: TestAccKMSKey_Policy_bypassUpdate (40.30s)
=== CONT  TestAccKMSKey_hmacKey
--- PASS: TestAccKMSKey_Policy_iamRoleUpdate (54.83s)
=== CONT  TestAccKMSKey_asymmetricKey
--- PASS: TestAccKMSKey_hmacKey (20.37s)
=== CONT  TestAccKMSKey_multiRegion
--- PASS: TestAccKMSKey_asymmetricKey (19.93s)
=== CONT  TestAccKMSAlias_updateKeyID
--- PASS: TestAccKMSKey_Policy_basic (44.95s)
=== CONT  TestAccKMSCiphertextDataSource_validate
--- PASS: TestAccKMSKey_multiRegion (25.46s)
=== CONT  TestAccKMSCiphertextDataSource_basic
--- PASS: TestAccKMSCiphertextDataSource_validate (20.34s)
=== CONT  TestAccKMSAlias_arnDiffSuppress
--- PASS: TestAccKMSCiphertextDataSource_basic (20.72s)
=== CONT  TestAccKMSAlias_multipleAliasesForSameKey
--- PASS: TestAccKMSAlias_updateKeyID (42.70s)
=== CONT  TestAccKMSKeyPolicy_iamRoleUpdate
--- PASS: TestAccKMSAlias_multipleAliasesForSameKey (24.92s)
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSAlias_arnDiffSuppress (33.17s)
=== CONT  TestAccKMSKeyPolicy_booleanCondition
--- PASS: TestAccKMSKeyPolicy_booleanCondition (28.81s)
=== CONT  TestAccKMSKeyPolicy_iamServiceLinkedRole
--- PASS: TestAccKMSKey_basic (37.36s)
=== CONT  TestAccKMSKeyPolicy_iamRoleOrder
--- PASS: TestAccKMSKeyPolicy_iamRoleUpdate (60.03s)
=== CONT  TestAccKMSKeyPolicy_keyIsEnabled
--- PASS: TestAccKMSKey_Policy_bypass (153.87s)
=== CONT  TestAccKMSKeyPolicy_iamRole
--- PASS: TestAccKMSKeyPolicy_iamServiceLinkedRole (51.29s)
=== CONT  TestAccKMSAlias_disappears
--- PASS: TestAccKMSKeyPolicy_iamRole (37.07s)
=== CONT  TestAccKMSAlias_namePrefix
--- PASS: TestAccKMSKeyPolicy_iamRoleOrder (58.39s)
=== CONT  TestAccKMSAlias_Name_generated
--- PASS: TestAccKMSAlias_disappears (20.51s)
=== CONT  TestAccKMSAlias_basic
--- PASS: TestAccKMSKeyPolicy_keyIsEnabled (77.27s)
=== CONT  TestAccKMSKeyPolicy_bypassUpdate
--- PASS: TestAccKMSAlias_namePrefix (28.66s)
=== CONT  TestAccKMSKeyPolicy_bypass
--- PASS: TestAccKMSAlias_Name_generated (28.86s)
=== CONT  TestAccKMSAliasDataSource_cmk
--- PASS: TestAccKMSAlias_basic (29.83s)
--- PASS: TestAccKMSAliasDataSource_cmk (20.68s)
--- PASS: TestAccKMSKeyPolicy_bypassUpdate (41.62s)
--- PASS: TestAccKMSKeyPolicy_bypass (212.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	1365.748s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKMSGrant_crossAccountARN' PKG=kms ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/kms/... -v -count 1 -parallel 4  -run=TestAccKMSGrant_crossAccountARN -timeout 720m
=== RUN   TestAccKMSGrant_crossAccountARN
=== PAUSE TestAccKMSGrant_crossAccountARN
=== CONT  TestAccKMSGrant_crossAccountARN
--- PASS: TestAccKMSGrant_crossAccountARN (39.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	50.833s

@ewbankkit
Copy link
Contributor

@aristosvo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4f828c0 into hashicorp:main May 3, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.49.0 milestone May 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/kms Issues and PRs that pertain to the kms service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.49.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] KMS (Key Management) Service
3 participants
@aristosvo @ewbankkit @jar-b